From 56a5d77c6ccdd1b808ea41852b268072a289a823 Mon Sep 17 00:00:00 2001 From: Vitor Hideyoshi Date: Sat, 11 Apr 2026 20:52:35 -0300 Subject: [PATCH] refactor: rename getSignedUrl to getPublicUrl for clarity in storage functions --- src/lib/storage/storage.adapter.ts | 1 - src/lib/storage/storage.external.ts | 2 +- src/lib/storage/storage.utils.ts | 4 ++-- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/lib/storage/storage.adapter.ts b/src/lib/storage/storage.adapter.ts index 02626ae..5ddc916 100644 --- a/src/lib/storage/storage.adapter.ts +++ b/src/lib/storage/storage.adapter.ts @@ -74,7 +74,6 @@ export class S3StorageAdapter implements StorageProvider { Bucket: this.bucketName, Key: key, ContentType: contentType, - ACL: ObjectCannedACL.public_read, }); return await getSignedUrl(this.s3Client, command, { expiresIn: 3600 }); diff --git a/src/lib/storage/storage.external.ts b/src/lib/storage/storage.external.ts index a97ebeb..2454490 100644 --- a/src/lib/storage/storage.external.ts +++ b/src/lib/storage/storage.external.ts @@ -7,7 +7,7 @@ import { TypedResult } from '@/utils/types/results'; const storage: StorageProvider = createStorageProvider(); -export const getSignedUrl = async ( +export const getPublicUrl = async ( key: string, storageProvider?: StorageProvider ): Promise> => { diff --git a/src/lib/storage/storage.utils.ts b/src/lib/storage/storage.utils.ts index 17461f8..cfc5dcf 100644 --- a/src/lib/storage/storage.utils.ts +++ b/src/lib/storage/storage.utils.ts @@ -26,7 +26,7 @@ export const uploadFile = wrap(async (file: File) => { const existsResult = await storage.checkExists(fileKey); if (existsResult) { - const presignedUrl = await storage.getSignedUrl(fileKey); + const presignedUrl = await storage.getPublicUrl(fileKey); if (!presignedUrl.ok) { throw new Error('Failed to retrieve file URL'); } @@ -48,7 +48,7 @@ export const uploadFile = wrap(async (file: File) => { throw new Error('Failed to upload file'); } - const presignedUrl = await storage.getSignedUrl(fileKey); + const presignedUrl = await storage.getPublicUrl(fileKey); if (!presignedUrl.ok) { throw new Error('Failed to retrieve file URL'); }