jambo/parser/allof_type_parser.py

@@ -74,10 +74,10 @@ class AllOfTypeParser(GenericTypeParser):
             return old_value + new_value
 
         if prop_name in ("maxLength", "maximum", "exclusiveMaximum"):
-            return old_value if old_value > new_value else new_value
+            return old_value if old_value < new_value else new_value
 
         if prop_name in ("minLength", "minimum", "exclusiveMinimum"):
-            return old_value if old_value < new_value else new_value
+            return old_value if old_value > new_value else new_value
 
         if prop_name == "properties":
             for key, value in new_value.items():

tests/parser/test_allof_type_parser.py

@@ -117,8 +117,8 @@ class TestAllOfTypeParser(TestCase):
         )
 
         self.assertEqual(type_parsing, str)
-        self.assertEqual(type_validator["max_length"], 11)
-        self.assertEqual(type_validator["min_length"], 1)
+        self.assertEqual(type_validator["max_length"], 4)
+        self.assertEqual(type_validator["min_length"], 2)
 
     def test_all_of_type_parser_in_fields(self):
         """
@@ -138,8 +138,8 @@ class TestAllOfTypeParser(TestCase):
         )
 
         self.assertEqual(type_parsing, str)
-        self.assertEqual(type_validator["max_length"], 11)
-        self.assertEqual(type_validator["min_length"], 1)
+        self.assertEqual(type_validator["max_length"], 4)
+        self.assertEqual(type_validator["min_length"], 2)
 
     def test_invalid_all_of(self):
         """

tests/test_schema_converter.py

@@ -358,10 +358,13 @@ class TestSchemaConverter(TestCase):
         Model = SchemaConverter.build(schema)
 
         obj = Model(
-            name="J",
+            name="John",
         )
 
-        self.assertEqual(obj.name, "J")
+        self.assertEqual(obj.name, "John")
+
+        with self.assertRaises(ValueError):
+            Model(name="J")
 
         with self.assertRaises(ValueError):
             Model(name="John Invalid")