refactor: simplify fixture creation in tests for HarvesterHandler and UpgraderHandler
This commit is contained in:
@@ -6,74 +6,73 @@ import {
|
||||
} from '@/utils/positions';
|
||||
import '~/tests/__mocks__/screeps';
|
||||
|
||||
// ─── Helpers ────────────────────────────────────────────────────────────────
|
||||
|
||||
function makeMatrix(fill: string = PositionSpotStatus.EMPTY) {
|
||||
const m = createSourcePositionMatrix(fill as any);
|
||||
return m;
|
||||
}
|
||||
|
||||
function makeState(overrides: Partial<GameState> = {}): GameState {
|
||||
const spots = makeMatrix();
|
||||
return {
|
||||
sourcesStates: {
|
||||
src1: { spots },
|
||||
},
|
||||
...overrides,
|
||||
} as unknown as GameState;
|
||||
}
|
||||
|
||||
function makeCreepMemory(overrides: Partial<CreepMemory> = {}): CreepMemory {
|
||||
return {
|
||||
role: 'harvester',
|
||||
spawnId: 'spawn1',
|
||||
...overrides,
|
||||
} as CreepMemory;
|
||||
}
|
||||
|
||||
function makeStore(used: number, capacity: number) {
|
||||
return {
|
||||
getFreeCapacity: (_res: string) => capacity - used,
|
||||
getUsedCapacity: (_res: string) => used,
|
||||
};
|
||||
}
|
||||
|
||||
function makePos(x = 0, y = 0, roomName = 'W1N1') {
|
||||
return new (global as any).RoomPosition(x, y, roomName);
|
||||
}
|
||||
|
||||
function makeSource(id = 'src1', x = 5, y = 5, roomName = 'W1N1') {
|
||||
return {
|
||||
id,
|
||||
pos: makePos(x, y, roomName),
|
||||
} as unknown as Source;
|
||||
}
|
||||
|
||||
function makeSpawn(id = 'spawn1') {
|
||||
return { id } as unknown as StructureSpawn;
|
||||
}
|
||||
|
||||
function makeCreep(
|
||||
memoryOverrides: Partial<CreepMemory> = {},
|
||||
storeUsed = 0,
|
||||
storeCapacity = 50
|
||||
): Creep {
|
||||
const memory = makeCreepMemory(memoryOverrides);
|
||||
return {
|
||||
name: 'Creep1',
|
||||
memory,
|
||||
store: makeStore(storeUsed, storeCapacity),
|
||||
pos: makePos(),
|
||||
room: {},
|
||||
harvest: jest.fn().mockReturnValue((global as any).OK),
|
||||
moveTo: jest.fn().mockReturnValue((global as any).OK),
|
||||
transfer: jest.fn().mockReturnValue((global as any).OK),
|
||||
} as unknown as Creep;
|
||||
}
|
||||
|
||||
// ─── Tests ───────────────────────────────────────────────────────────────────
|
||||
|
||||
describe('HarvesterHandler', () => {
|
||||
type FixtureOptions = {
|
||||
memory?: Partial<CreepMemory>;
|
||||
storeUsed?: number;
|
||||
storeCapacity?: number;
|
||||
stateOverrides?: Partial<GameState>;
|
||||
sourceId?: string;
|
||||
spawnId?: string;
|
||||
};
|
||||
|
||||
const createFixture = ({
|
||||
memory = {},
|
||||
storeUsed = 0,
|
||||
storeCapacity = 50,
|
||||
stateOverrides = {},
|
||||
sourceId = 'src1',
|
||||
spawnId = 'spawn1',
|
||||
}: FixtureOptions = {}) => {
|
||||
const state = {
|
||||
sourcesStates: {
|
||||
[sourceId]: {
|
||||
spots: createSourcePositionMatrix(
|
||||
PositionSpotStatus.EMPTY as any
|
||||
),
|
||||
},
|
||||
},
|
||||
...stateOverrides,
|
||||
} as unknown as GameState;
|
||||
|
||||
const source = {
|
||||
id: sourceId,
|
||||
pos: new (global as any).RoomPosition(5, 5, 'W1N1'),
|
||||
} as unknown as Source;
|
||||
|
||||
const spawn = { id: spawnId } as unknown as StructureSpawn;
|
||||
|
||||
const creep = {
|
||||
name: 'Creep1',
|
||||
memory: {
|
||||
role: 'harvester',
|
||||
spawnId,
|
||||
...memory,
|
||||
} as CreepMemory,
|
||||
store: {
|
||||
getFreeCapacity: (_res: string) => storeCapacity - storeUsed,
|
||||
getUsedCapacity: (_res: string) => storeUsed,
|
||||
},
|
||||
pos: new (global as any).RoomPosition(0, 0, 'W1N1'),
|
||||
room: {},
|
||||
harvest: jest.fn().mockReturnValue((global as any).OK),
|
||||
moveTo: jest.fn().mockReturnValue((global as any).OK),
|
||||
transfer: jest.fn().mockReturnValue((global as any).OK),
|
||||
} as unknown as Creep;
|
||||
|
||||
return {
|
||||
state,
|
||||
source,
|
||||
spawn,
|
||||
creep,
|
||||
memory: creep.memory,
|
||||
mockSource: (value: Source | null = source) =>
|
||||
jest.spyOn(getById, 'getSourceById').mockReturnValue(value),
|
||||
mockSpawn: (value: StructureSpawn | null = spawn) =>
|
||||
jest.spyOn(getById, 'getSpawnById').mockReturnValue(value),
|
||||
};
|
||||
};
|
||||
|
||||
beforeEach(() => {
|
||||
jest.clearAllMocks();
|
||||
jest.spyOn(console, 'log').mockImplementation(() => {});
|
||||
@@ -83,16 +82,14 @@ describe('HarvesterHandler', () => {
|
||||
jest.restoreAllMocks();
|
||||
});
|
||||
|
||||
// ── destroy ──────────────────────────────────────────────────────────────
|
||||
|
||||
describe('destroy', () => {
|
||||
it('releases the source spot from destination and clears it', () => {
|
||||
const state = makeState();
|
||||
state.sourcesStates['src1'].spots[0] = PositionSpotStatus.OCCUPIED;
|
||||
|
||||
const memory = makeCreepMemory({
|
||||
destination: { type: 'source', id: 'src1', sourceSpot: 0 },
|
||||
const { state, memory } = createFixture({
|
||||
memory: {
|
||||
destination: { type: 'source', id: 'src1', sourceSpot: 0 },
|
||||
},
|
||||
});
|
||||
state.sourcesStates['src1'].spots[0] = PositionSpotStatus.OCCUPIED;
|
||||
|
||||
HarvesterHandler.destroy(memory, state);
|
||||
|
||||
@@ -103,16 +100,16 @@ describe('HarvesterHandler', () => {
|
||||
});
|
||||
|
||||
it('releases the source spot from previousDestination and clears it', () => {
|
||||
const state = makeState();
|
||||
state.sourcesStates['src1'].spots[2] = PositionSpotStatus.OCCUPIED;
|
||||
|
||||
const memory = makeCreepMemory({
|
||||
previousDestination: {
|
||||
type: 'source',
|
||||
id: 'src1',
|
||||
sourceSpot: 2,
|
||||
const { state, memory } = createFixture({
|
||||
memory: {
|
||||
previousDestination: {
|
||||
type: 'source',
|
||||
id: 'src1',
|
||||
sourceSpot: 2,
|
||||
},
|
||||
},
|
||||
});
|
||||
state.sourcesStates['src1'].spots[2] = PositionSpotStatus.OCCUPIED;
|
||||
|
||||
HarvesterHandler.destroy(memory, state);
|
||||
|
||||
@@ -123,14 +120,14 @@ describe('HarvesterHandler', () => {
|
||||
});
|
||||
|
||||
it('does nothing when destination is not a source', () => {
|
||||
const state = makeState();
|
||||
const memory = makeCreepMemory({
|
||||
destination: { type: 'spawn', id: 'spawn1' },
|
||||
const { state, memory } = createFixture({
|
||||
memory: {
|
||||
destination: { type: 'spawn', id: 'spawn1' },
|
||||
},
|
||||
});
|
||||
|
||||
HarvesterHandler.destroy(memory, state);
|
||||
|
||||
// None of the source spots should have changed
|
||||
expect(
|
||||
state.sourcesStates['src1'].spots.every(
|
||||
(s: PositionSpotStatus) =>
|
||||
@@ -141,29 +138,25 @@ describe('HarvesterHandler', () => {
|
||||
});
|
||||
|
||||
it('does nothing when memory has no destination', () => {
|
||||
const state = makeState();
|
||||
const memory = makeCreepMemory();
|
||||
const { state, memory } = createFixture();
|
||||
|
||||
expect(() => HarvesterHandler.destroy(memory, state)).not.toThrow();
|
||||
});
|
||||
});
|
||||
|
||||
// ── validateCreepMemory (via run) ────────────────────────────────────────
|
||||
|
||||
describe('validateCreepMemory (via run)', () => {
|
||||
it('releases previousDestination source spot and deletes it', () => {
|
||||
const state = makeState();
|
||||
state.sourcesStates['src1'].spots[1] = PositionSpotStatus.OCCUPIED;
|
||||
|
||||
const creep = makeCreep({
|
||||
previousDestination: {
|
||||
type: 'source',
|
||||
id: 'src1',
|
||||
sourceSpot: 1,
|
||||
const { state, creep, mockSource } = createFixture({
|
||||
memory: {
|
||||
previousDestination: {
|
||||
type: 'source',
|
||||
id: 'src1',
|
||||
sourceSpot: 1,
|
||||
},
|
||||
},
|
||||
});
|
||||
|
||||
jest.spyOn(getById, 'getSourceById').mockReturnValue(null);
|
||||
state.sourcesStates['src1'].spots[1] = PositionSpotStatus.OCCUPIED;
|
||||
mockSource(null);
|
||||
|
||||
HarvesterHandler.run(creep, state);
|
||||
|
||||
@@ -174,19 +167,16 @@ describe('HarvesterHandler', () => {
|
||||
});
|
||||
|
||||
it('transitions from source to spawn destination when energy is full', () => {
|
||||
const state = makeState();
|
||||
const source = makeSource();
|
||||
jest.spyOn(getById, 'getSourceById').mockReturnValue(source);
|
||||
jest.spyOn(getById, 'getSpawnById').mockReturnValue(makeSpawn());
|
||||
|
||||
const creep = makeCreep(
|
||||
{
|
||||
const { state, creep, mockSource, mockSpawn } = createFixture({
|
||||
memory: {
|
||||
destination: { type: 'source', id: 'src1', sourceSpot: 0 },
|
||||
spawnId: 'spawn1',
|
||||
},
|
||||
50, // used = full
|
||||
50
|
||||
);
|
||||
storeUsed: 50,
|
||||
storeCapacity: 50,
|
||||
});
|
||||
mockSource();
|
||||
mockSpawn();
|
||||
|
||||
HarvesterHandler.run(creep, state);
|
||||
|
||||
@@ -195,16 +185,14 @@ describe('HarvesterHandler', () => {
|
||||
});
|
||||
|
||||
it('clears spawn destination when energy is empty', () => {
|
||||
const state = makeState();
|
||||
jest.spyOn(getById, 'getSpawnById').mockReturnValue(makeSpawn());
|
||||
|
||||
const creep = makeCreep(
|
||||
{
|
||||
const { state, creep, mockSpawn } = createFixture({
|
||||
memory: {
|
||||
destination: { type: 'spawn', id: 'spawn1' },
|
||||
},
|
||||
0, // used = 0
|
||||
50
|
||||
);
|
||||
storeUsed: 0,
|
||||
storeCapacity: 50,
|
||||
});
|
||||
mockSpawn();
|
||||
|
||||
HarvesterHandler.run(creep, state);
|
||||
|
||||
@@ -212,14 +200,10 @@ describe('HarvesterHandler', () => {
|
||||
});
|
||||
});
|
||||
|
||||
// ── onFindNewSource ───────────────────────────────────────────────────────
|
||||
|
||||
describe('onFindNewSource', () => {
|
||||
it('assigns the first available source spot to the creep', () => {
|
||||
const state = makeState();
|
||||
jest.spyOn(getById, 'getSourceById').mockReturnValue(makeSource());
|
||||
|
||||
const creep = makeCreep(); // no destination, empty store
|
||||
const { state, creep, mockSource } = createFixture();
|
||||
mockSource();
|
||||
|
||||
HarvesterHandler.run(creep, state);
|
||||
|
||||
@@ -228,18 +212,13 @@ describe('HarvesterHandler', () => {
|
||||
});
|
||||
|
||||
it('does not assign a source when all spots are occupied', () => {
|
||||
const state = makeState();
|
||||
// Fill all non-center spots with OCCUPIED
|
||||
const { state, creep, mockSource } = createFixture();
|
||||
state.sourcesStates['src1'].spots = state.sourcesStates[
|
||||
'src1'
|
||||
].spots.map((s: PositionSpotStatus) =>
|
||||
s === PositionSpotStatus.CENTER
|
||||
? s
|
||||
: PositionSpotStatus.OCCUPIED
|
||||
s === PositionSpotStatus.CENTER ? s : PositionSpotStatus.OCCUPIED
|
||||
) as any;
|
||||
|
||||
jest.spyOn(getById, 'getSourceById').mockReturnValue(makeSource());
|
||||
const creep = makeCreep();
|
||||
mockSource();
|
||||
|
||||
HarvesterHandler.run(creep, state);
|
||||
|
||||
@@ -247,19 +226,14 @@ describe('HarvesterHandler', () => {
|
||||
});
|
||||
});
|
||||
|
||||
// ── onSourceDestination ───────────────────────────────────────────────────
|
||||
|
||||
describe('onSourceDestination', () => {
|
||||
it('harvests when in range', () => {
|
||||
const state = makeState();
|
||||
const source = makeSource();
|
||||
jest.spyOn(getById, 'getSourceById').mockReturnValue(source);
|
||||
|
||||
const creep = makeCreep(
|
||||
{ destination: { type: 'source', id: 'src1', sourceSpot: 0 } },
|
||||
0,
|
||||
50
|
||||
);
|
||||
const { state, source, creep, mockSource } = createFixture({
|
||||
memory: {
|
||||
destination: { type: 'source', id: 'src1', sourceSpot: 0 },
|
||||
},
|
||||
});
|
||||
mockSource();
|
||||
(creep.harvest as jest.Mock).mockReturnValue((global as any).OK);
|
||||
|
||||
HarvesterHandler.run(creep, state);
|
||||
@@ -269,15 +243,12 @@ describe('HarvesterHandler', () => {
|
||||
});
|
||||
|
||||
it('moves to source when not in range', () => {
|
||||
const state = makeState();
|
||||
const source = makeSource();
|
||||
jest.spyOn(getById, 'getSourceById').mockReturnValue(source);
|
||||
|
||||
const creep = makeCreep(
|
||||
{ destination: { type: 'source', id: 'src1', sourceSpot: 0 } },
|
||||
0,
|
||||
50
|
||||
);
|
||||
const { state, creep, mockSource } = createFixture({
|
||||
memory: {
|
||||
destination: { type: 'source', id: 'src1', sourceSpot: 0 },
|
||||
},
|
||||
});
|
||||
mockSource();
|
||||
(creep.harvest as jest.Mock).mockReturnValue(
|
||||
(global as any).ERR_NOT_IN_RANGE
|
||||
);
|
||||
@@ -288,39 +259,32 @@ describe('HarvesterHandler', () => {
|
||||
});
|
||||
|
||||
it('logs and returns when source is not found', () => {
|
||||
const state = makeState();
|
||||
jest.spyOn(getById, 'getSourceById').mockReturnValue(null);
|
||||
|
||||
const creep = makeCreep(
|
||||
{
|
||||
const { state, creep, mockSource } = createFixture({
|
||||
memory: {
|
||||
destination: {
|
||||
type: 'source',
|
||||
id: 'unknown',
|
||||
sourceSpot: 0,
|
||||
},
|
||||
},
|
||||
0,
|
||||
50
|
||||
);
|
||||
});
|
||||
mockSource(null);
|
||||
|
||||
expect(() => HarvesterHandler.run(creep, state)).not.toThrow();
|
||||
expect(creep.harvest).not.toHaveBeenCalled();
|
||||
});
|
||||
});
|
||||
|
||||
// ── onSpawnDestination ────────────────────────────────────────────────────
|
||||
|
||||
describe('onSpawnDestination', () => {
|
||||
it('transfers energy when in range', () => {
|
||||
const state = makeState();
|
||||
const spawn = makeSpawn();
|
||||
jest.spyOn(getById, 'getSpawnById').mockReturnValue(spawn);
|
||||
|
||||
const creep = makeCreep(
|
||||
{ destination: { type: 'spawn', id: 'spawn1' } },
|
||||
50,
|
||||
50
|
||||
);
|
||||
const { state, spawn, creep, mockSpawn } = createFixture({
|
||||
memory: {
|
||||
destination: { type: 'spawn', id: 'spawn1' },
|
||||
},
|
||||
storeUsed: 50,
|
||||
storeCapacity: 50,
|
||||
});
|
||||
mockSpawn();
|
||||
(creep.transfer as jest.Mock).mockReturnValue((global as any).OK);
|
||||
|
||||
HarvesterHandler.run(creep, state);
|
||||
@@ -333,15 +297,14 @@ describe('HarvesterHandler', () => {
|
||||
});
|
||||
|
||||
it('moves to spawn when not in range', () => {
|
||||
const state = makeState();
|
||||
const spawn = makeSpawn();
|
||||
jest.spyOn(getById, 'getSpawnById').mockReturnValue(spawn);
|
||||
|
||||
const creep = makeCreep(
|
||||
{ destination: { type: 'spawn', id: 'spawn1' } },
|
||||
50,
|
||||
50
|
||||
);
|
||||
const { state, spawn, creep, mockSpawn } = createFixture({
|
||||
memory: {
|
||||
destination: { type: 'spawn', id: 'spawn1' },
|
||||
},
|
||||
storeUsed: 50,
|
||||
storeCapacity: 50,
|
||||
});
|
||||
mockSpawn();
|
||||
(creep.transfer as jest.Mock).mockReturnValue(
|
||||
(global as any).ERR_NOT_IN_RANGE
|
||||
);
|
||||
@@ -355,14 +318,14 @@ describe('HarvesterHandler', () => {
|
||||
});
|
||||
|
||||
it('logs and returns when spawn is not found', () => {
|
||||
const state = makeState();
|
||||
jest.spyOn(getById, 'getSpawnById').mockReturnValue(null);
|
||||
|
||||
const creep = makeCreep(
|
||||
{ destination: { type: 'spawn', id: 'spawn1' } },
|
||||
50,
|
||||
50
|
||||
);
|
||||
const { state, creep, mockSpawn } = createFixture({
|
||||
memory: {
|
||||
destination: { type: 'spawn', id: 'spawn1' },
|
||||
},
|
||||
storeUsed: 50,
|
||||
storeCapacity: 50,
|
||||
});
|
||||
mockSpawn(null);
|
||||
|
||||
expect(() => HarvesterHandler.run(creep, state)).not.toThrow();
|
||||
expect(creep.transfer).not.toHaveBeenCalled();
|
||||
|
||||
Reference in New Issue
Block a user