HideyoshiNakazone/jambo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 12 Wiki Activity

feat: more pythonic error parent class #48

Merged
HideyoshiNakazone merged 1 commits from feature/explicit-exception-type into main 2025-09-14 04:42:11 +00:00
Conversation 0 Commits 1 Files Changed 2 +2 -2
HideyoshiNakazone commented 2025-09-14 04:41:43 +00:00 (Migrated from github.com)
Copy Link

This pull request updates the exception hierarchy for InternalAssertionException to improve how internal assertion errors are handled and tested.

Exception hierarchy update:

  • Changed the base class of InternalAssertionException from AssertionError to RuntimeError in jambo/exceptions/internal_assertion_exception.py.

Test adjustments:

  • Updated the inheritance test in tests/exceptions/test_internal_assertion_exception.py to check that InternalAssertionException is a subclass of RuntimeError instead of AssertionError.
This pull request updates the exception hierarchy for `InternalAssertionException` to improve how internal assertion errors are handled and tested. Exception hierarchy update: * Changed the base class of `InternalAssertionException` from `AssertionError` to `RuntimeError` in `jambo/exceptions/internal_assertion_exception.py`. Test adjustments: * Updated the inheritance test in `tests/exceptions/test_internal_assertion_exception.py` to check that `InternalAssertionException` is a subclass of `RuntimeError` instead of `AssertionError`.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
HideyoshiNakazone
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: HideyoshiNakazone/jambo#48
Delete Branch "feature/explicit-exception-type"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?