feat: Add examples #54

2025-11-17T22:44:21Z

JCHacking commented

2025-11-17 22:44:21 +00:00

(Migrated from github.com)

Refs: #52

HideyoshiNakazone commented

2025-11-23 05:35:06 +00:00

(Migrated from github.com)

Hi @JCHacking , how are you? I liked your draft so i forked your branch and made some fixes that were missing for it to fully work and created the MR #56. All your commits have been preserved.

If you like we can procede to merge the MR i created or you can pull from my branch that has been referenced in the MR #56 so we can make the merge in this MR.

Best regards,
Vitor Hideyoshi.

Hi @JCHacking , how are you? I liked your draft so i forked your branch and made some fixes that were missing for it to fully work and created the MR #56. All your commits have been preserved. If you like we can procede to merge the MR i created or you can pull from my branch that has been referenced in the MR #56 so we can make the merge in this MR. Best regards, Vitor Hideyoshi.

JCHacking commented

2025-11-23 16:58:46 +00:00

(Migrated from github.com)

Hi @HideyoshiNakazone
Yes, I think it's fine to merge that branch into this one, so we can continue working on this feature.

Now I was thinking about how to implement the rest of the complex objects, because there may be examples there.
We would have to pass them on or something, since, for example, if it's a string, depending on the format further in, it's one object or another.

Hi @HideyoshiNakazone Yes, I think it's fine to merge that branch into this one, so we can continue working on this feature. Now I was thinking about how to implement the rest of the complex objects, because there may be examples there. We would have to pass them on or something, since, for example, if it's a string, depending on the format further in, it's one object or another.

HideyoshiNakazone commented

2025-11-23 17:46:50 +00:00

(Migrated from github.com)

I've reserved some time today to get this feature implemented and merge, i have just finished implementing examples for objects, now i'm implementing examples to list. After that there's still the parsers AnyOf, OneOf and AllOf.

❤️ 1

codecov[bot] commented

2025-11-23 20:35:17 +00:00

(Migrated from github.com)

Codecov Report

❌ Patch coverage is 97.56098% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
jambo/parser/string_type_parser.py	93.33%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

## [Codecov](https://app.codecov.io/gh/HideyoshiNakazone/jambo/pull/54?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vitor+Hideyoshi) Report :x: Patch coverage is `97.56098%` with `1 line` in your changes missing coverage. Please review. | [Files with missing lines](https://app.codecov.io/gh/HideyoshiNakazone/jambo/pull/54?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vitor+Hideyoshi) | Patch % | Lines | |---|---|---| | [jambo/parser/string\_type\_parser.py](https://app.codecov.io/gh/HideyoshiNakazone/jambo/pull/54?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vitor+Hideyoshi#diff-amFtYm8vcGFyc2VyL3N0cmluZ190eXBlX3BhcnNlci5weQ==) | 93.33% | [1 Missing :warning: ](https://app.codecov.io/gh/HideyoshiNakazone/jambo/pull/54?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vitor+Hideyoshi) | :loudspeaker: Thoughts on this report? [Let us know!](https://github.com/codecov/feedback/issues/255)

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: HideyoshiNakazone/jambo#54