HideyoshiNakazone/jambo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 12 Wiki Activity

fix: fixes annotation definition in anyof parser #71

Merged
HideyoshiNakazone merged 1 commits from fix/fixes-annotation-definition-anyof into main 2025-11-28 21:30:38 +00:00
Conversation 1 Commits 1 Files Changed 1 +7 -3
HideyoshiNakazone commented 2025-11-28 21:30:11 +00:00 (Migrated from github.com)
Copy Link

This pull request refactors how default values are handled when constructing union types with field validators in the from_properties_impl method of jambo/parser/anyof_type_parser.py. The main change is to explicitly extract and set default values for each sub-type, ensuring that defaults are correctly applied in the annotated fields.

Field validator and default value handling:

  • Refactored the construction of field_types to explicitly extract and set the default value from each sub-type's properties, using ... as a fallback when no default is provided. This ensures that default values are correctly passed to the Field constructor for each annotated type.
This pull request refactors how default values are handled when constructing union types with field validators in the `from_properties_impl` method of `jambo/parser/anyof_type_parser.py`. The main change is to explicitly extract and set default values for each sub-type, ensuring that defaults are correctly applied in the annotated fields. Field validator and default value handling: * Refactored the construction of `field_types` to explicitly extract and set the `default` value from each sub-type's properties, using `...` as a fallback when no default is provided. This ensures that default values are correctly passed to the `Field` constructor for each annotated type.
HideyoshiNakazone commented 2025-11-28 21:31:15 +00:00 (Migrated from github.com)
Copy Link

Solves #69

Solves #69
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
HideyoshiNakazone
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: HideyoshiNakazone/jambo#71
Delete Branch "fix/fixes-annotation-definition-anyof"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?