HideyoshiNakazone/jambo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 12 Wiki Activity

feat: support object-level descriptions #78

Merged
mikix merged 2 commits from model-desc into main 2026-01-14 19:14:35 +00:00
Conversation 3 Commits 2 Files Changed 6 +25 -1
mikix commented 2026-01-14 18:16:11 +00:00 (Migrated from github.com)
Copy Link

By saving them as a pydantic model docstring.

Fixes https://github.com/HideyoshiNakazone/jambo/issues/77

(also adds docstrings on enums, as a very similar fix)

By saving them as a pydantic model docstring. Fixes https://github.com/HideyoshiNakazone/jambo/issues/77 (also adds docstrings on enums, as a very similar fix)
mikix commented 2026-01-14 19:08:34 +00:00 (Migrated from github.com)
Copy Link

If approved/merged, I'd love a small release with this, if you don't mind.

If approved/merged, I'd love a small release with this, if you don't mind.
codecov[bot] commented 2026-01-14 19:11:32 +00:00 (Migrated from github.com)
Copy Link

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

## [Codecov](https://app.codecov.io/gh/HideyoshiNakazone/jambo/pull/78?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vitor+Hideyoshi) Report :white_check_mark: All modified and coverable lines are covered by tests. :loudspeaker: Thoughts on this report? [Let us know!](https://github.com/codecov/feedback/issues/255)
HideyoshiNakazone commented 2026-01-14 19:14:31 +00:00 (Migrated from github.com)
Copy Link

Hey @mikix, thanks for the PR! I liked the implementation and will be approving it. Thanks a lot for the contribution!

Hey @mikix, thanks for the PR! I liked the implementation and will be approving it. Thanks a lot for the contribution!
❤️ 1
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
HideyoshiNakazone
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: HideyoshiNakazone/jambo#78
Delete Branch "model-desc"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?