HideyoshiNakazone/jambo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 12 Wiki Activity

feat: Add binary and file-path string format support #79

Closed
joelbarmettlerUZH wants to merge 1 commits from main into main
pull from: main
merge into: HideyoshiNakazone:main
Conversation 2 Commits 1 Files Changed 2 +29 -2
joelbarmettlerUZH commented 2026-01-21 15:20:51 +00:00 (Migrated from github.com)
Copy Link

Add support for two additional JSON Schema string formats:

  • 'binary' -> bytes (for base64-encoded binary data)
  • 'file-path' -> FilePath (for filesystem paths)
Add support for two additional JSON Schema string formats: - 'binary' -> bytes (for base64-encoded binary data) - 'file-path' -> FilePath (for filesystem paths)
codecov[bot] commented 2026-01-25 00:07:54 +00:00 (Migrated from github.com)
Copy Link

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

## [Codecov](https://app.codecov.io/gh/HideyoshiNakazone/jambo/pull/79?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vitor+Hideyoshi) Report :white_check_mark: All modified and coverable lines are covered by tests. :loudspeaker: Thoughts on this report? [Let us know!](https://github.com/codecov/feedback/issues/255)
HideyoshiNakazone commented 2026-01-25 00:17:10 +00:00 (Migrated from github.com)
Copy Link

Hey @joelbarmettlerUZH , thanks for the PR. However, these keywords aren’t valid format keywords under the JSON Schema Specification
. Since I’m aiming to keep this project as closely aligned with the official specification as possible, I won’t be merging this PR.

Once again, thanks for the PR and i'm sorry it doesn't fit this project scope. Feel free to send PR for any keyword under the specification or bug fixes :)

Hey @joelbarmettlerUZH , thanks for the PR. However, these keywords aren’t valid format keywords under the [JSON Schema Specification](https://json-schema.org/draft/2020-12/draft-bhutton-json-schema-validation-00#format) . Since I’m aiming to keep this project as closely aligned with the official specification as possible, I won’t be merging this PR. Once again, thanks for the PR and i'm sorry it doesn't fit this project scope. Feel free to send PR for any keyword under the specification or bug fixes :)
👍 1

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
HideyoshiNakazone
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: HideyoshiNakazone/jambo#79
Delete Branch "main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?